#86dtu93ty - Include how to write nft contracts (NEP-11) to the docum… #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meevee98
suggested changes
Jun 19, 2024
docs/source/getting-started.md
Outdated
Comment on lines
140
to
148
| For **non-divisible** NFT contracts, the following method is also required: | ||
| - `balanceOf` - Returns the total amount of NFTs of the specified account. | ||
| - `transfer` - Transfers tokens to a specified account. | ||
| - `ownerOf` - Returns the address of the owner of a specified NFT ID. | ||
|
|
||
| For **divisible** NFT contracts, the following methods are also required: | ||
| - `balanceOf` - Returns the amount of NFTs of the specified NFT ID for the specified account. | ||
| - `transfer` - Transfers tokens to from a specified account to another. | ||
| - `ownerOf` - Returns the addresses of all co-owners of a specified NFT ID. |
There was a problem hiding this comment.
the method names are the same for each case, it should need to explain before this that the signatures are different, not only what each method returns
docs/source/getting-started.md
Outdated
Comment on lines
154
to
155
| Here's a [full example](https://github.com/CityOfZion/neo3-boa/blob/development/boa3_test/examples/nep11_non_divisible.py) of a non-divisible token contract following the NEP-11 standard. | ||
| >Note: The example above is rather complete and contains more than just the basic implementation of a NEP-11 contract. Once again, be sure to check the [full documentation](https://docs.neo.org/docs/en-us/develop/write/nep11.html) on the NEP-11 standard to ensure the implementation is correct. |
There was a problem hiding this comment.
I just saw that you pasted the direct link to development branch, can you change it to relative path, so when it's merged to staging and master it links to the respective versions?
Same for the nep17 example
meevee98
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary or solution description
Adds instructions on how to create a NEP-11 contract to the getting started documentation